Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: New Crowdin updates #4428

Merged
merged 486 commits into from
Aug 6, 2023
Merged

fix: New Crowdin updates #4428

merged 486 commits into from
Aug 6, 2023

Conversation

teolemon
Copy link
Member

@teolemon teolemon commented Aug 3, 2023

No description provided.

@teolemon teolemon requested a review from a team as a code owner August 3, 2023 17:12
@github-actions github-actions bot added 🍎 iOS iOS specific issues or PRs 🌐 l10n labels Aug 3, 2023
@teolemon teolemon changed the title New Crowdin updates fix: New Crowdin updates Aug 3, 2023
@teolemon
Copy link
Member Author

teolemon commented Aug 3, 2023

Running 'flutter pub upgrade' in /home/runner/work/smooth-app/smooth-app/packages/smooth_app
Generating synthetic localizations package failed with 1 error:

Exception: The following .arb file's locale could not be determined:
/home/runner/work/smooth-app/smooth-app/packages/smooth_app/lib/l10n/app_ach.arb
Make sure that the locale is specified in the file's '@@Locale' property or as part of the filename (e.g. file_en.arb)
Error: Process completed with exit code 1.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

You can test this PR on: Android

@M123-dev
Copy link
Member

M123-dev commented Aug 5, 2023

uhm thats a large PR 👀

@codecov-commenter
Copy link

Codecov Report

Merging #4428 (8407589) into develop (a5e1808) will increase coverage by 0.18%.
Report is 17 commits behind head on develop.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4428      +/-   ##
===========================================
+ Coverage    10.17%   10.36%   +0.18%     
===========================================
  Files          295      296       +1     
  Lines        15093    15241     +148     
===========================================
+ Hits          1535     1579      +44     
- Misses       13558    13662     +104     

see 25 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@teolemon teolemon merged commit e9a67b1 into develop Aug 6, 2023
10 checks passed
@teolemon teolemon deleted the l10n_develop branch August 6, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍎 iOS iOS specific issues or PRs 🌐 l10n
Development

Successfully merging this pull request may close these issues.

3 participants